Alignment main-dxp with legacy/5.X #23

plozinski · 2024-06-13T17:32:14Z

Summary

Motivation

Changes

Test plan

Fix for tvOS native audio menu language selector commit: a42240d

Adding Dolby Atmos workaround. commit: 3030ddd comment: - Add and remove spatial audio remote command handler - Whenever we play video, we must add this event handler that returns a success status for all remote command events - Whenever we stop video or destroy the player, remove this event handler - This is a workaround to get Dolby Atmos working on iOS 15 and above

It seems, that if we have several Video elements and if we remove handler, spatial sound will stop working. commit: b1fa382 comment: How to reproduce: Two videos. First with autoplay. Second paused with controls. Also handler adding moved from play/pause method to setSrc, because if we show paused video with native controls - our play method is not called.

Revert iOS 15 MPRemoteCommandCenter workaround commit: ac1114e

feat: put back dolby atmos workaround work commit: c58d9dd

Send current time request and handle command result on iOS. commit: dbba295

Attempt to sync two videos. commit: 300794d

Fix autoplay & playing after buffering commit: 8a15097

Send on played tracks change commit: 69cd4f0 comment: adding files of M3U8Kit it is part of work from: Feature/xhub 5315 (#14) (commit: a6823bb)

Add podspec with m3u8 parser commit: b2d2ecf

Add proper audio parsing commit: 2c55b87

Removed unused method commit: ce29859

Fix displaying string uri commit: 320985f

Feature/xhub 5315 (#14) commit: a6823bb comment: * Add checking values statements * Add video codec * Add library to code itself to fix problem with spaces in uri

XHUB-5327 - Expose channel (HLS) and Dolby SupplementalProperty (DASH) values from currently played resource to ReactNative (#17) commit: 675207f comment: * Add license text * Add channels

src/Video.tsx

romansavka-mq · 2024-06-14T08:51:46Z

Do poprawy napewno failujące check'i GithubActions. Nie budują się samplowe aplikacje iOS'owe.
Wyszła dziwna nazwa branch'a main-dxp+legacy/5.X, / wyszedł jako folder. Można zmienić na ios/dxp-5.x-alignment
Do dodania opis zmian w CHANGELOG
Do dodania dokumentacja nowych property/method (np. principalVideo/peripheralVideo)

Po zminie branch'a i utworzeniu nowego PR'a zacznę dodawać uwagi do plków.

romansavka-mq · 2024-06-14T09:00:26Z

ios/Video/RCTVideoManager.m

@@ -57,12 +59,17 @@ @interface RCT_EXTERN_MODULE (RCTVideoManager, RCTViewManager)
 RCT_EXPORT_VIEW_PROPERTY(onPlaybackStalled, RCTDirectEventBlock);
 RCT_EXPORT_VIEW_PROPERTY(onPlaybackResume, RCTDirectEventBlock);
 RCT_EXPORT_VIEW_PROPERTY(onPlaybackRateChange, RCTDirectEventBlock);
+RCT_EXPORT_VIEW_PROPERTY(onPlayedTracksChange, RCTDirectEventBlock);


Czy jesteśmy w stanie dostosować to do implementacji open-source, gdzie są trzy callbacki

https://thewidlarzgroup.github.io/react-native-video/component/events#onaudiotracks
https://thewidlarzgroup.github.io/react-native-video/component/events#onvideotracks
https://thewidlarzgroup.github.io/react-native-video/component/events#ontexttracks

Co ważne onaudiotracks / ontexttracks są zaimplementowane dla iOS według dokumentacji open-source

?

tak spróbuję

romansavka-mq · 2024-06-14T09:02:05Z

ios/Video/RCTVideoManager.m

 RCT_EXPORT_VIEW_PROPERTY(onVolumeChange, RCTDirectEventBlock);
 RCT_EXPORT_VIEW_PROPERTY(onVideoPlaybackStateChanged, RCTDirectEventBlock);
 RCT_EXPORT_VIEW_PROPERTY(onVideoExternalPlaybackChange, RCTDirectEventBlock);
 RCT_EXPORT_VIEW_PROPERTY(onGetLicense, RCTDirectEventBlock);
 RCT_EXPORT_VIEW_PROPERTY(onPictureInPictureStatusChanged, RCTDirectEventBlock);
 RCT_EXPORT_VIEW_PROPERTY(onRestoreUserInterfaceForPictureInPictureStop, RCTDirectEventBlock);
+
+RCT_EXPORT_VIEW_PROPERTY(onCommandResult, RCTBubblingEventBlock);
+RCT_EXTERN_METHOD(getCurrentTime : (nonnull NSNumber*)rectTag reactTag : (nonnull NSNumber*)commandId commandId)


Wydaje się że możemy usunąć tą implementacje bo jest zaimplementowane w open-source

https://thewidlarzgroup.github.io/react-native-video/component/methods#getcurrentposition

Musimy tylko zaktualizować main-dxp zmianami które wyszły w 6.2.0 open-source. Zrobimy to po zakończeniu tego wyrównania z 5.X

okej, usunę ten commit

This reverts commit 3a903b2.

plozinski added 15 commits June 12, 2024 12:23

from:

744f050

Fix for tvOS native audio menu language selector commit: a42240d

from:

84e5c58

Revert iOS 15 MPRemoteCommandCenter workaround commit: ac1114e

from:

23dab1f

feat: put back dolby atmos workaround work commit: c58d9dd

from:

3a903b2

Send current time request and handle command result on iOS. commit: dbba295

from:

5e3132e

Attempt to sync two videos. commit: 300794d

from:

1a47e35

Fix autoplay & playing after buffering commit: 8a15097

from:

1960c34

Send on played tracks change commit: 69cd4f0 comment: adding files of M3U8Kit it is part of work from: Feature/xhub 5315 (#14) (commit: a6823bb)

from:

4605fef

Add podspec with m3u8 parser commit: b2d2ecf

from:

cab2919

Add proper audio parsing commit: 2c55b87

from:

927d692

Removed unused method commit: ce29859

from:

a83755b

Fix displaying string uri commit: 320985f

from:

4736c31

Feature/xhub 5315 (#14) commit: a6823bb comment: * Add checking values statements * Add video codec * Add library to code itself to fix problem with spaces in uri

from:

06a7230

XHUB-5327 - Expose channel (HLS) and Dolby SupplementalProperty (DASH) values from currently played resource to ReactNative (#17) commit: 675207f comment: * Add license text * Add channels

github-actions bot reviewed Jun 13, 2024

View reviewed changes

src/Video.tsx Outdated Show resolved Hide resolved

src/Video.tsx Outdated Show resolved Hide resolved

src/Video.tsx Outdated Show resolved Hide resolved

src/Video.tsx Outdated Show resolved Hide resolved

sh scripts/swift-format.sh

4174ef4

github-actions bot reviewed Jun 13, 2024

View reviewed changes

src/Video.tsx Show resolved Hide resolved

src/Video.tsx Show resolved Hide resolved

src/Video.tsx Outdated Show resolved Hide resolved

src/Video.tsx Outdated Show resolved Hide resolved

src/Video.tsx Outdated Show resolved Hide resolved

romansavka-mq reviewed Jun 14, 2024

View reviewed changes

plozinski force-pushed the main-dxp+legacy/5.X branch 3 times, most recently from a70ea47 to ea5f907 Compare June 14, 2024 17:57

plozinski and others added 4 commits June 14, 2024 20:24

make lint happy

b94214a

Update names in Video.tsx

facf558

sh scripts/clang-format.sh

d604093

JS fixes

83cfe3b

plozinski force-pushed the main-dxp+legacy/5.X branch from ea5f907 to 93ad73b Compare June 14, 2024 18:34

fix swift errors

6cec1c7

plozinski force-pushed the main-dxp+legacy/5.X branch from 93ad73b to 6cec1c7 Compare June 14, 2024 18:37

plozinski added 2 commits June 14, 2024 21:53

Revert "from:"

5ea059c

This reverts commit 3a903b2.

Replace onPlayedTracksChange with 3 callbacks.

1b96ed6

plozinski closed this Jun 16, 2024

plozinski deleted the main-dxp+legacy/5.X branch June 16, 2024 20:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alignment main-dxp with legacy/5.X #23

Alignment main-dxp with legacy/5.X #23

plozinski commented Jun 13, 2024

romansavka-mq commented Jun 14, 2024 •

edited

Loading

romansavka-mq Jun 14, 2024 •

edited

Loading

plozinski Jun 14, 2024

romansavka-mq Jun 14, 2024

plozinski Jun 14, 2024

Alignment main-dxp with legacy/5.X #23

Alignment main-dxp with legacy/5.X #23

Conversation

plozinski commented Jun 13, 2024

Summary

Motivation

Changes

Test plan

romansavka-mq commented Jun 14, 2024 • edited Loading

romansavka-mq Jun 14, 2024 • edited Loading

Choose a reason for hiding this comment

plozinski Jun 14, 2024

Choose a reason for hiding this comment

romansavka-mq Jun 14, 2024

Choose a reason for hiding this comment

plozinski Jun 14, 2024

Choose a reason for hiding this comment

romansavka-mq commented Jun 14, 2024 •

edited

Loading

romansavka-mq Jun 14, 2024 •

edited

Loading